Skip to content

fix: update slot key filtering to exclude internal keys #2167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged

fix: update slot key filtering to exclude internal keys #2167

merged 1 commit into from
Apr 18, 2025
+1 −1

Conversation

edison1105
Copy link
Contributor

We will add another internal key __, see https://github.com/vuejs/core/pull/13215/files

@edison1105 edison1105 mentioned this pull request Apr 18, 2025
Merged
@kazupon kazupon added the Type: Improvement Includes backwards-compatible fixes label Apr 18, 2025
@github-actions GitHub Actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
core.esm-browser.prod.js 38.05 kB 11.62 kB 10.39 kB
core.global.prod.js 31.11 kB 10.78 kB 9.67 kB
core.runtime.esm-browser.prod.js 23.77 kB 7.71 kB 6.90 kB
core.runtime.global.prod.js 18.08 kB 7.04 kB 6.32 kB
message-compiler.esm-browser.prod.js 19.29 kB 5.76 kB 5.14 kB
message-compiler.global.prod.js 17.32 kB 5.55 kB 4.98 kB
petite-vue-i18n-core.esm-browser.prod.js 20.67 kB 6.96 kB 6.26 kB
petite-vue-i18n-core.global.prod.js 15.63 kB 6.06 kB 5.51 kB
petite-vue-i18n.esm-browser.prod.js 36.98 kB 11.34 kB 10.17 kB
petite-vue-i18n.global.prod.js 29.84 kB 10.19 kB 9.20 kB
petite-vue-i18n.runtime.esm-browser.prod.js 22.55 kB 7.33 kB 6.63 kB
petite-vue-i18n.runtime.global.prod.js 16.83 kB 6.40 kB 5.80 kB
vue-i18n.esm-browser.prod.js 50.66 kB (+0.00 kB) 15.15 kB (+0.00 kB) 13.54 kB (+0.00 kB)
vue-i18n.global.prod.js 40.53 kB (+0.00 kB) 13.60 kB (+0.00 kB) 12.25 kB (+0.01 kB)
vue-i18n.runtime.esm-browser.prod.js 36.23 kB (+0.00 kB) 11.15 kB (+0.00 kB) 10.02 kB (+0.00 kB)
vue-i18n.runtime.global.prod.js 27.52 kB (+0.00 kB) 9.85 kB (+0.00 kB) 8.89 kB (+0.00 kB)

Usages

Name Size Gzip Brotli
packages/size-check-core (@intlify/core) 9.22 kB 3.82 kB 3.46 kB
packages/size-check-petite-vue-i18n (petite-vue-i18n) 77.63 kB 30.24 kB 27.28 kB
packages/size-check-vue-i18n (vue-i18n) 82.83 kB 31.74 kB 28.51 kB

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 18, 2025

Open in StackBlitz

@intlify/core

npm i https://pkg.pr.new/@intlify/core@2167

@intlify/core-base

npm i https://pkg.pr.new/@intlify/core-base@2167

@intlify/devtools-types

npm i https://pkg.pr.new/@intlify/devtools-types@2167

@intlify/message-compiler

npm i https://pkg.pr.new/@intlify/message-compiler@2167

petite-vue-i18n

npm i https://pkg.pr.new/petite-vue-i18n@2167

@intlify/shared

npm i https://pkg.pr.new/@intlify/shared@2167

vue-i18n

npm i https://pkg.pr.new/vue-i18n@2167

@intlify/vue-i18n-core

npm i https://pkg.pr.new/@intlify/vue-i18n-core@2167

commit: ffe6d51

kazupon
kazupon approved these changes Apr 18, 2025
View reviewed changes
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kazupon kazupon merged commit a353b6b into intlify:master Apr 18, 2025
28 checks passed
@davidwessman
Copy link

davidwessman commented May 23, 2025 •
edited
Loading

We are currently getting errors on i18n-t components using two slots or more after upgrading to Vue 3.5.14.

Will this be release in a new v11 version soon?

Edit:
Managed to recreate it on stackblitz, so created an issue:
#2189

@davidwessman davidwessman mentioned this pull request May 23, 2025
Closed
4 tasks
@kazupon
Copy link
Member

kazupon commented May 24, 2025

Ah, Sorry, I've not backed port from master branch to v11 branch.
I'll do it.

@kazupon kazupon mentioned this pull request May 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees
No one assigned
Labels
Type: Improvement Includes backwards-compatible fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edison1105 @davidwessman @kazupon